-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modal: Convert component to TypeScript #42949
Conversation
Size Change: +25 B (0%) Total Size: 1.27 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beautiful, thank you! 🚢
No rush, but just checking up on this one since you haven't merged yet 😄 |
Yes. Forgot about this one 🙈. I will resolve merge conflicts later today so we can get it merged. |
Hey @mirka I've updated the PR and resolved the merge conflicts. Can you take another look at the PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
Thanks for taking a second look after the rebase @mirka. |
What?
Refactor the
Modal
component to TypeScript.Why?
Part of the @wordpress/components's TypeScript migration (#35744).
How?
Testing Instructions